<html>
<head><meta charset="utf-8"><title>A way to self-label soundness issues? · general · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/index.html">general</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html">A way to self-label soundness issues?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="240719086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240719086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Frank Steffahn <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240719086">(May 29 2021 at 20:16)</a>:</h4>
<p>With some personal history of coming across soundness issues <a href="https://github.com/rust-lang/rust/issues?q=is%3Aissue+label%3A%22I-unsound+%F0%9F%92%A5%22+author%3Asteffahn">rather frequently</a> in the recent past, I’m regularly relying on team members to apply the <code>I-unsound 💥</code> label for me. Is there any reason, in principle, why there is (AFAICT) no way to assign the label with rustbot? Especially considering the fact that regression labels <em>can</em> also be set by anyone now, why not unsound labels? <del>And I’d be happy if anyone can set the label manually for <a href="https://github.com/rust-lang/rust/issues/85813">#85813</a> in the meantime <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></del></p>



<a name="240841558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240841558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> fee1-dead <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240841558">(May 31 2021 at 14:44)</a>:</h4>
<p>I think one reason can be it is undesirable for everyone to be able to trigger a zulip message using a simple comment. How about allow users who have contributed at least once to set that label. </p>
<p>Maybe the <code>needs-fcp</code> label could also be permitted to be set by anyone (or a contributor)? Because I came across <a href="https://github.com/rust-lang/rust/pull/85835">#85835</a> and wanted to add the label.</p>



<a name="240849698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240849698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Frank Steffahn <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240849698">(May 31 2021 at 16:04)</a>:</h4>
<p>What do you mean by “trigger a zulip message”? The prioritization? That applies to regressions labels as-well which – as I mentioned – <em>can</em> be set using <code>rustbot</code>.</p>



<a name="240855155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240855155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240855155">(May 31 2021 at 17:12)</a>:</h4>
<p>I think the <code>I-prioritization</code> label is meant to be usable by anyone though, there is even a special <code>@rustbot prioritize</code> command for it</p>



<a name="240855957"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240855957" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240855957">(May 31 2021 at 17:23)</a>:</h4>
<p>Also, shouldn't it be allowed? In the <a href="https://github.com/rust-lang/rust/blob/master/triagebot.toml"><code>triagebot.toml</code></a>, there is:</p>
<div class="codehilite" data-code-language="TOML"><pre><span></span><code>    <span class="c1"># I-* without I-nominated</span>
    <span class="s">"I-*"</span><span class="p">,</span> <span class="s">"!I-nominated"</span><span class="p">,</span>
</code></pre></div>
<p>Shouldn't <code>I-unsound 💥</code> match <code>I-*</code>?</p>



<a name="240870984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240870984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Frank Steffahn <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240870984">(May 31 2021 at 21:04)</a>:</h4>
<p><span class="user-mention silent" data-user-id="255061">Léo Lanteri Thauvin</span> <a href="#narrow/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F/near/240855957">said</a>:</p>
<blockquote>
<p>Also, shouldn't it be allowed?</p>
</blockquote>
<p>Hm… this is something I kind-of already suspected. Thus the <code>AFAICT</code> in my own statement:</p>
<blockquote>
<p>there is (AFAICT) no way to assign the label with rustbot</p>
</blockquote>
<p>The reason then might be that, AFAICT, there’s no way to give <code>rustbot</code> a label that contains spaces <span aria-label="wink" class="emoji emoji-1f609" role="img" title="wink">:wink:</span></p>
<p>I have looked into the documentation and I think even parts of the source code for rustbot and there might in fact be no way to pass a label with spaces. I’m not too motivated to play around with it all that much either anyway, because rustbot error message are <em>terrible spam</em>. They never go away and quickly start cluttering your issue threads.</p>



<a name="240872858"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240872858" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240872858">(May 31 2021 at 21:30)</a>:</h4>
<p>Oh, well that's much more easily fixable, you should have started with that :P</p>



<a name="240873012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240873012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240873012">(May 31 2021 at 21:33)</a>:</h4>
<p>it's accurate that there's no way to pass spaces in</p>



<a name="240873020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240873020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240873020">(May 31 2021 at 21:33)</a>:</h4>
<p>IMO the "better" fix there is just to cut spaces from the label name</p>



<a name="240873030"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240873030" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240873030">(May 31 2021 at 21:34)</a>:</h4>
<p>we really don't need an exploding emoji either</p>



<a name="240962907"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240962907" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240962907">(Jun 01 2021 at 15:52)</a>:</h4>
<blockquote>
<p>IMO the "better" fix there is just to cut spaces from the label name</p>
</blockquote>
<p>Doing that now</p>



<a name="240963117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240963117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240963117">(Jun 01 2021 at 15:54)</a>:</h4>
<p>Done, <span class="user-mention" data-user-id="280891">@Frank Steffahn</span> you should be able to add the label on your own now</p>



<a name="240965305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240965305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Frank Steffahn <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240965305">(Jun 01 2021 at 16:09)</a>:</h4>
<p>One relevant part of the triagebot.toml <a href="https://github.com/rust-lang/rust/blob/master/triagebot.toml">linked above</a></p>
<div class="codehilite"><pre><span></span><code>[autolabel.&quot;I-prioritize&quot;]
trigger_labels = [
    &quot;regression-untriaged&quot;,
    &quot;regression-from-stable-to-stable&quot;,
    &quot;regression-from-stable-to-beta&quot;,
    &quot;regression-from-stable-to-nightly&quot;,
    &quot;I-unsound 💥&quot;,
]
</code></pre></div>
<p>might need updating, too?</p>



<a name="240967387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240967387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240967387">(Jun 01 2021 at 16:24)</a>:</h4>
<p><span class="user-mention" data-user-id="280891">@Frank Steffahn</span> can you make a PR for that? I don't have time now, sorry</p>



<a name="240968127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122651-general/topic/A%20way%20to%20self-label%20soundness%20issues%3F/near/240968127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Frank Steffahn <a href="https://rust-lang.github.io/zulip_archive/stream/122651-general/topic/A.20way.20to.20self-label.20soundness.20issues.3F.html#240968127">(Jun 01 2021 at 16:29)</a>:</h4>
<p>Okay, done <a href="https://github.com/rust-lang/rust/issues/85897">#85897</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>